Yaml Parser#858
Merged
Merged
Conversation
Comment on lines
+8
to
+10
| - gridname : "WUT" | ||
| fieldname_code : "potato" | ||
| fieldname_file : "mullions" |
| yaml_file_id2 = open_and_parse_file("data_table.yaml") | ||
| if (yaml_file_id2 .ne. 1) call mpp_error(FATAL, "The yaml_file_id for this file should be 1") | ||
|
|
||
| !< ----------------------------------- |
Contributor
There was a problem hiding this comment.
All of the routine comments should be preceded by !> instead of !<
rem1776
reviewed
Nov 10, 2021
rem1776
approved these changes
Nov 12, 2021
rem1776
requested changes
Nov 12, 2021
Contributor
rem1776
left a comment
There was a problem hiding this comment.
Sorry, approved this then tried running the tests when I saw it could be merged. The parser test will need to either copy the test yamls or generate them into the build directory, since the test will fail if it's built anywhere but the source .
rem1776
approved these changes
Nov 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--with-yamlto autotools that checks that the environment is set up correctly and adds the-Duse_yamlmacro to your compilation.To do:
--with-yamlFixes # (issue)
How Has This Been Tested?
intel21 and gnu 9.3 on skylake
Checklist:
make distcheckpasses